gavinchou commented on code in PR #35819:
URL: https://github.com/apache/doris/pull/35819#discussion_r1632065322
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/catalog/CloudClusterChecker.java:
##########
@@ -70,7 +70,6 @@ private <T> void diffNodes(List<T> toAdd, List<T> toDel,
Supplier<Map<String, T>
return;
}
- // TODO(gavin): Consider VPC
Review Comment:
Do not delete this TODO
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/catalog/CloudClusterChecker.java:
##########
@@ -449,6 +447,8 @@ private void getCloudBackends() {
// local - remote > 0, drop bes from local
checkToDelCluster(remoteClusterIdToPB, localClusterIds,
clusterIdToBackend);
+ clusterIdToBackend =
cloudSystemInfoService.getCloudClusterIdToBackend();
Review Comment:
Is this a bug fix not related to smooth upgrade?
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/util/StatisticsUtil.java:
##########
@@ -480,6 +481,9 @@ public static boolean statsTblAvailable() {
return false;
}
if (Config.isCloudMode()) {
+ if (!((CloudSystemInfoService)
Env.getCurrentSystemInfo()).availableBackendsExists()) {
Review Comment:
Is this another bug fix not related to smooth upgrade?
##########
be/src/service/http_service.cpp:
##########
@@ -225,6 +226,10 @@ Status HttpService::start() {
register_local_handler(engine.to_local());
}
+ // shrink memory for starting co-exist process during upgrade
+ ShrinkMemAction* shrink_mem_action = _pool.add(new ShrinkMemAction());
+ _ev_http_server->register_handler(HttpMethod::GET, "/api/shrink_mem",
shrink_mem_action);
Review Comment:
Put these new lines before line 222, before this section
```
auto& engine = _env->storage_engine();
if (config::is_cloud_mode()) {
register_cloud_handler(engine.to_cloud());
} else {
register_local_handler(engine.to_local());
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
