This is an automated email from the ASF dual-hosted git repository.

dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
     new ac670f849ad [improve](cloud) The cloudWarmUpJob save/load is supported 
for image (#35979)
ac670f849ad is described below

commit ac670f849ad920a0bbc7ed6346ce7cbfe18b4e6c
Author: Lightman <31928846+lchangli...@users.noreply.github.com>
AuthorDate: Fri Jun 7 14:11:39 2024 +0800

    [improve](cloud) The cloudWarmUpJob save/load is supported for image 
(#35979)
    
    The cloudWarmUpJob save/load is supported in
    ```
    // 
fe/fe-core/src/main/java/org/apache/doris/persist/meta/MetaPersistMethod.java
    case "cloudWarmUpJob":
                    metaPersistMethod.readMethod =
                            Env.class.getDeclaredMethod("loadCloudWarmUpJob", 
DataInputStream.class, long.class);
                    metaPersistMethod.writeMethod =
                            Env.class.getDeclaredMethod("saveCloudWarmUpJob", 
CountingDataOutputStream.class, long.class);
                    break;
    ```
    Remove the skip code.
---
 .../src/main/java/org/apache/doris/persist/meta/MetaReader.java  | 9 ---------
 1 file changed, 9 deletions(-)

diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/persist/meta/MetaReader.java 
b/fe/fe-core/src/main/java/org/apache/doris/persist/meta/MetaReader.java
index 8eb913d7f69..8024105fe26 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/persist/meta/MetaReader.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/persist/meta/MetaReader.java
@@ -100,15 +100,6 @@ public class MetaReader {
                     LOG.info("Skip {} module since empty meta length in the 
end.", metaIndex.name);
                     continue;
                 }
-                // FIXME: pick cloudWarmUpJob and remove below codes.
-                if (metaIndex.name.equals("cloudWarmUpJob")) {
-                    LOG.warn("meta modules {} is not supported yet, ignore and 
skip it", metaIndex.name);
-                    // If this is the last module, nothing need to do.
-                    if (i < metaFooter.metaIndices.size() - 1) {
-                        IOUtils.skipFully(dis, metaFooter.metaIndices.get(i + 
1).offset - metaIndex.offset);
-                    }
-                    continue;
-                }
                 // skip deprecated modules
                 if 
(PersistMetaModules.DEPRECATED_MODULE_NAMES.contains(metaIndex.name)) {
                     LOG.warn("meta modules {} is deprecated, ignore and skip 
it", metaIndex.name);


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to