github-actions[bot] commented on code in PR #35838:
URL: https://github.com/apache/doris/pull/35838#discussion_r1629667946
##########
be/src/cloud/cloud_engine_calc_delete_bitmap_task.cpp:
##########
@@ -135,33 +95,74 @@ Status CloudEngineCalcDeleteBitmapTask::execute() {
}
CloudTabletCalcDeleteBitmapTask::CloudTabletCalcDeleteBitmapTask(
- CloudStorageEngine& engine, CloudEngineCalcDeleteBitmapTask*
engine_task,
- std::shared_ptr<CloudTablet> tablet, int64_t transaction_id, int64_t
version)
+ CloudStorageEngine& engine, CloudEngineCalcDeleteBitmapTask*
engine_task, int64_t tablet_id,
+ int64_t transaction_id, int64_t version)
: _engine(engine),
_engine_calc_delete_bitmap_task(engine_task),
- _tablet(tablet),
+ _tablet_id(tablet_id),
_transaction_id(transaction_id),
_version(version) {
_mem_tracker = MemTrackerLimiter::create_shared(
MemTrackerLimiter::Type::OTHER,
fmt::format("CloudTabletCalcDeleteBitmapTask#_transaction_id={}",
_transaction_id));
}
-void CloudTabletCalcDeleteBitmapTask::handle() const {
+Status CloudTabletCalcDeleteBitmapTask::handle() const {
Review Comment:
warning: function 'handle' exceeds recommended size/complexity thresholds
[readability-function-size]
```cpp
Status CloudTabletCalcDeleteBitmapTask::handle() const {
^
```
<details>
<summary>Additional context</summary>
**be/src/cloud/cloud_engine_calc_delete_bitmap_task.cpp:109:** 84 lines
including whitespace and comments (threshold 80)
```cpp
Status CloudTabletCalcDeleteBitmapTask::handle() const {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
