HappenLee commented on code in PR #35913:
URL: https://github.com/apache/doris/pull/35913#discussion_r1628879488


##########
be/src/pipeline/exec/scan_operator.cpp:
##########
@@ -743,6 +746,14 @@ Status 
ScanLocalState<Derived>::_normalize_not_in_and_not_eq_predicate(
     PushDownType temp_pdt = PushDownType::UNACCEPTABLE;
     // 1. Normalize in conjuncts like 'where col in (v1, v2, v3)'
     if (TExprNodeType::IN_PRED == expr->node_type()) {
+        /// `VDirectInPredicate` here should not be pushed down.
+        /// here means the `VDirectInPredicate` is too big to be converted 
into `ColumnValueRange`.
+        /// For non-key columns and `_storage_no_merge()` is false, this 
predicate should not be pushed down.
+        if (expr->get_set_func() != nullptr) {

Review Comment:
   rf seems not be not in?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to