XieJiann commented on code in PR #35898:
URL: https://github.com/apache/doris/pull/35898#discussion_r1628714500
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalCatalogRelation.java:
##########
@@ -128,20 +127,6 @@ public String qualifiedName() {
@Override
public void computeUnique(DataTrait.Builder builder) {
Set<Slot> outputSet = Utils.fastToImmutableSet(getOutputSet());
- if (table instanceof OlapTable && ((OlapTable)
table).getKeysType().isAggregationFamily()) {
- ImmutableSet.Builder<Slot> uniqSlots =
ImmutableSet.builderWithExpectedSize(outputSet.size());
- for (Slot slot : outputSet) {
- if (!(slot instanceof SlotReference)) {
- continue;
- }
- SlotReference slotRef = (SlotReference) slot;
- if (slotRef.getColumn().isPresent() &&
slotRef.getColumn().get().isKey()) {
- uniqSlots.add(slot);
- }
- }
- builder.addUniqueSlot(uniqSlots.build());
- }
-
Review Comment:
Add a condition to check if it is a mv rather than remove those codes. They
are useful if it's a trivial olapscan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
