This is an automated email from the ASF dual-hosted git repository.

morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git


The following commit(s) were added to refs/heads/master by this push:
     new aee9273  [typo] translate comment in Chinese to English in 
SingleNodePlanner (#8038)
aee9273 is described below

commit aee9273a094a290104be0367e7cffad5fcd07b05
Author: dataroaring <98214048+dataroar...@users.noreply.github.com>
AuthorDate: Wed Feb 16 11:57:12 2022 +0800

    [typo] translate comment in Chinese to English in SingleNodePlanner (#8038)
---
 .../src/main/java/org/apache/doris/planner/SingleNodePlanner.java  | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java 
b/fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java
index 3b4dba7..b3aaf2a 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java
@@ -711,8 +711,11 @@ public class SingleNodePlanner {
             candidates.add(new Pair<>(ref, new Long(materializedSize)));
             LOG.debug("The candidate of " + ref.getUniqueAlias() + ": " + 
materializedSize);
         }
-        // (ML): 这里感觉是不可能运行到的,因为起码第一个节点是inner join
-        if (candidates.isEmpty()) return null;
+        if (candidates.isEmpty()) {
+            // This branch should not be reached, because the first one should 
be inner join.
+            LOG.warn("Something wrong happens, the code should not be runned");
+            return null;
+        }
 
         // order candidates by descending materialized size; we want to 
minimize the memory
         // consumption of the materialized hash tables required for the join 
sequence

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to