BiteTheDDDDt commented on code in PR #35841:
URL: https://github.com/apache/doris/pull/35841#discussion_r1626048782
##########
be/src/vec/common/uint128.h:
##########
@@ -152,31 +64,10 @@ struct UInt128HashCRC32 : public UInt128Hash {};
#endif
struct UInt128TrivialHash {
- size_t operator()(UInt128 x) const { return x.low; }
+ size_t operator()(UInt128 x) const { return x.items[0]; }
Review Comment:
UInt128 using integer<128, unsigned> now, there are not only 128-bit
situations, but also other types such as UInt256, which share the name `items`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
