HappenLee commented on code in PR #35628:
URL: https://github.com/apache/doris/pull/35628#discussion_r1625927972
##########
be/src/olap/rowset/segment_v2/column_reader.cpp:
##########
@@ -72,13 +74,135 @@
#include "vec/common/schema_util.h"
#include "vec/common/string_ref.h"
#include "vec/core/types.h"
+#include "vec/data_types/data_type_agg_state.h"
+#include "vec/data_types/data_type_factory.hpp"
#include "vec/runtime/vdatetime_value.h" //for VecDateTime
namespace doris {
namespace segment_v2 {
static bvar::Adder<size_t>
g_column_reader_memory_bytes("doris_column_reader_memory_bytes");
static bvar::Adder<size_t> g_column_reader_num("doris_column_reader_num");
+Status ColumnReader::create_array(const ColumnReaderOptions& opts, const
ColumnMetaPB& meta,
+ uint64_t num_rows, const io::FileReaderSPtr&
file_reader,
+ std::unique_ptr<ColumnReader>* reader) {
+ DCHECK(meta.children_columns_size() == 2 || meta.children_columns_size()
== 3);
+
+ std::unique_ptr<ColumnReader> item_reader;
+ RETURN_IF_ERROR(ColumnReader::create(opts, meta.children_columns(0),
+ meta.children_columns(0).num_rows(),
file_reader,
+ &item_reader));
+
+ std::unique_ptr<ColumnReader> offset_reader;
+ RETURN_IF_ERROR(ColumnReader::create(opts, meta.children_columns(1),
+ meta.children_columns(1).num_rows(),
file_reader,
+ &offset_reader));
+
+ std::unique_ptr<ColumnReader> null_reader;
+ if (meta.is_nullable()) {
+ RETURN_IF_ERROR(ColumnReader::create(opts, meta.children_columns(2),
+
meta.children_columns(2).num_rows(), file_reader,
+ &null_reader));
+ }
+
+ // The num rows of the array reader equals to the num rows of the length
reader.
+ num_rows = meta.children_columns(1).num_rows();
Review Comment:
the `num_rows` is param, but set value in the function ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
