yiguolei commented on code in PR #35806: URL: https://github.com/apache/doris/pull/35806#discussion_r1624160632
########## be/src/vec/functions/url/functions_url.h: ########## @@ -73,8 +73,8 @@ using Pos = const char*; */ template <typename Extractor> struct ExtractSubstringImpl { - static void vector(const ColumnString::Chars& data, const ColumnString::Offsets& offsets, Review Comment: why change this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org