github-actions[bot] commented on code in PR #35789:
URL: https://github.com/apache/doris/pull/35789#discussion_r1623858099
##########
be/test/util/bitmap_value_test.cpp:
##########
@@ -1174,27 +1019,20 @@ TEST(BitmapValueTest, Roaring64Map) {
size_t size_after = r1.getSizeInBytes(1);
EXPECT_LT(size_after, size_before);
- Roaring64Map r2 = Roaring64Map::bitmapOf(5, 1ull, 2ull, 234294967296ull,
195839473298ull,
- 14000000000000000100ull);
+ Roaring64Map r2;
+ r2.add((uint64_t)1);
+ r2.add((uint64_t)2);
+ r2.add((uint64_t)234294967296);
+ r2.add((uint64_t)195839473298);
+ r2.add((uint64_t)14000000000000000100ull);
Review Comment:
warning: integer literal has suffix 'ull', which is not uppercase
[readability-uppercase-literal-suffix]
```suggestion
r2.add((uint64_t)14000000000000000100ULL);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
