github-actions[bot] commented on code in PR #29641:
URL: https://github.com/apache/doris/pull/29641#discussion_r1623837340
##########
be/src/pipeline/exec/aggregation_sink_operator.cpp:
##########
@@ -535,6 +578,108 @@ void
AggSinkLocalState::_emplace_into_hash_table(vectorized::AggregateDataPtr* p
_agg_data->method_variant);
}
+bool
AggSinkLocalState::_emplace_into_hash_table_limit(vectorized::AggregateDataPtr*
places,
Review Comment:
warning: function '_emplace_into_hash_table_limit' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
bool
AggSinkLocalState::_emplace_into_hash_table_limit(vectorized::AggregateDataPtr*
places,
^
```
<details>
<summary>Additional context</summary>
**be/src/pipeline/exec/aggregation_sink_operator.cpp:580:** 96 lines
including whitespace and comments (threshold 80)
```cpp
bool
AggSinkLocalState::_emplace_into_hash_table_limit(vectorized::AggregateDataPtr*
places,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
