XieJiann commented on code in PR #35773:
URL: https://github.com/apache/doris/pull/35773#discussion_r1623757638
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/cost/CostModelV1.java:
##########
@@ -364,6 +364,13 @@ public Cost visitPhysicalHashJoin(
} else if (probeStats.getWidthInJoinCluster() <
buildStats.getWidthInJoinCluster()) {
leftRowCount += 1;
}
+ if (probeStats.getWidthInJoinCluster() ==
buildStats.getWidthInJoinCluster()
+ && probeStats.computeSize() < buildStats.computeSize()) {
+ // When the number of rows and the width on both sides of the
join are the same,
Review Comment:
There is an equal row count condition outside already. And the
computeTupleSize is private. When row count is same, the computSize is same to
computeTupleSize
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
