xiaokang commented on code in PR #35734:
URL: https://github.com/apache/doris/pull/35734#discussion_r1622492637
##########
be/src/olap/utils.h:
##########
@@ -260,6 +260,10 @@ constexpr bool is_numeric_type(const FieldType&
field_type) {
field_type == FieldType::OLAP_FIELD_TYPE_BOOL;
}
+constexpr bool is_ip_type(const FieldType& field_type) {
Review Comment:
not necessary
##########
be/src/olap/rowset/segment_v2/column_reader.cpp:
##########
@@ -573,7 +573,7 @@ Status ColumnReader::_load_inverted_index_index(
"create StringTypeInvertedIndexReader error: {}",
e.what());
}
}
- } else if (is_numeric_type(type)) {
+ } else if (is_numeric_type(type) || is_ip_type(type)) {
Review Comment:
is_numeric_type() should be the same as field_is_numeric_type() and
is_ip_type() can be removed here.
##########
be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:
##########
@@ -695,6 +695,8 @@ Status InvertedIndexColumnWriter::create(const Field* field,
M(FieldType::OLAP_FIELD_TYPE_DECIMAL128I)
M(FieldType::OLAP_FIELD_TYPE_DECIMAL256)
M(FieldType::OLAP_FIELD_TYPE_BOOL)
+ M(FieldType::OLAP_FIELD_TYPE_IPV4)
+ M(FieldType::OLAP_FIELD_TYPE_IPV6)
Review Comment:
Where is the code for transform encoding from little endian to big endian?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
