xinyiZzz commented on code in PR #35647:
URL: https://github.com/apache/doris/pull/35647#discussion_r1621840461
##########
be/src/olap/rowset/segment_v2/indexed_column_reader.cpp:
##########
@@ -56,6 +56,8 @@ static bvar::Adder<uint64_t>
g_index_reader_pk_pages("doris_pk", "index_reader_p
static bvar::PerSecond<bvar::Adder<uint64_t>>
g_index_reader_pk_bytes_per_second(
"doris_pk", "index_reader_pk_pages_per_second",
&g_index_reader_pk_pages, 60);
+static bvar::Adder<uint64_t>
g_index_reader_memory_bytes("doris_index_reader_memory_bytes");
Review Comment:
should create a global MemTracker for this counter
##########
be/src/olap/rowset/segment_v2/column_reader.cpp:
##########
@@ -77,6 +77,9 @@
namespace doris {
namespace segment_v2 {
+static bvar::Adder<size_t>
g_column_reader_memory_bytes("doris_column_reader_memory_bytes");
Review Comment:
should create a global MemTracker for this counter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
