yujun777 commented on code in PR #34889:
URL: https://github.com/apache/doris/pull/34889#discussion_r1621594362


##########
be/src/olap/tablet_manager.cpp:
##########
@@ -1307,6 +1264,18 @@ void TabletManager::unregister_clone_tablet(int64_t 
tablet_id) {
     shard.tablets_under_clone.erase(tablet_id);
 }
 
+std::pair<std::map<doris::TabletSchemaPath, std::string>::iterator, bool> 
TabletManager::register_transition_tablet(int64_t tablet_id, TSchemaHash 
schema_hash, size_t path_hash, std::string reason) {

Review Comment:
   return type is Status,  when register fail, maybe return 
Status::Error("tablet xxx is doing yyy").
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to