SWJTU-ZhangLei commented on code in PR #35653:
URL: https://github.com/apache/doris/pull/35653#discussion_r1620321280
##########
fe/fe-core/src/main/java/org/apache/doris/persist/EditLog.java:
##########
@@ -2102,4 +2102,17 @@ public String getNotReadyReason() {
}
return "";
}
+
+ public boolean exceedMaxJournalSize(BackupJob job) {
+ try {
+ return exceedMaxJournalSize(OperationType.OP_BACKUP_JOB, job);
+ } catch (Exception e) {
+ LOG.warn("exceedMaxJournalSize exception:", e);
+ }
+ return true;
+ }
+
+ private boolean exceedMaxJournalSize(short op, Writable writable) throws
IOException {
Review Comment:
> This function is redundant if we do not care about `op`
opCode is important, we will print opCode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
