morrySnow commented on code in PR #35619: URL: https://github.com/apache/doris/pull/35619#discussion_r1620288188
########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/ArrayReverseSplit.java: ########## @@ -0,0 +1,86 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.expressions.functions.scalar; + +import org.apache.doris.catalog.FunctionSignature; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.functions.PropagateNullable; +import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor; +import org.apache.doris.nereids.types.ArrayType; +import org.apache.doris.nereids.types.BooleanType; +import org.apache.doris.nereids.types.DataType; +import org.apache.doris.nereids.types.coercion.AnyDataType; + +import com.google.common.collect.ImmutableList; + +import java.util.List; + +/** + * ScalarFunction 'array_reverse_split'. + */ +public class ArrayReverseSplit extends ScalarFunction implements PropagateNullable, HighOrderFunction { + public static final List<FunctionSignature> SIGNATURES = ImmutableList.of( + FunctionSignature.retArgType(0).args(ArrayType.of(AnyDataType.INSTANCE_WITHOUT_INDEX), + ArrayType.of(BooleanType.INSTANCE))); Review Comment: ```suggestion FunctionSignature.ret(ArrayType.of(new FollowToArgumentType(0))).args(ArrayType.of(AnyDataType.INSTANCE_WITHOUT_INDEX), ArrayType.of(BooleanType.INSTANCE))); ``` ########## fe/fe-core/src/main/java/org/apache/doris/catalog/BuiltinScalarFunctions.java: ########## @@ -501,6 +503,8 @@ public class BuiltinScalarFunctions implements FunctionHelper { scalar(ArraySort.class, "array_sort"), scalar(ArraySortBy.class, "array_sortby"), scalar(ArrayShuffle.class, "array_shuffle", "shuffle"), + scalar(ArraySplit.class, "array_split"), + scalar(ArrayReverseSplit.class, "array_reverse_split"), Review Comment: Sort in alphabetical order ########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/ArraySplit.java: ########## @@ -0,0 +1,86 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.expressions.functions.scalar; + +import org.apache.doris.catalog.FunctionSignature; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.functions.PropagateNullable; +import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor; +import org.apache.doris.nereids.types.ArrayType; +import org.apache.doris.nereids.types.BooleanType; +import org.apache.doris.nereids.types.DataType; +import org.apache.doris.nereids.types.coercion.AnyDataType; + +import com.google.common.collect.ImmutableList; + +import java.util.List; + +/** + * ScalarFunction 'array_split'. + */ +public class ArraySplit extends ScalarFunction implements PropagateNullable, HighOrderFunction { + public static final List<FunctionSignature> SIGNATURES = ImmutableList.of( + FunctionSignature.retArgType(0).args(ArrayType.of(AnyDataType.INSTANCE_WITHOUT_INDEX), Review Comment: same as reverseSplit ########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/ArrayReverseSplit.java: ########## @@ -0,0 +1,86 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.expressions.functions.scalar; + +import org.apache.doris.catalog.FunctionSignature; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.functions.PropagateNullable; +import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor; +import org.apache.doris.nereids.types.ArrayType; +import org.apache.doris.nereids.types.BooleanType; +import org.apache.doris.nereids.types.DataType; +import org.apache.doris.nereids.types.coercion.AnyDataType; + +import com.google.common.collect.ImmutableList; + +import java.util.List; + +/** + * ScalarFunction 'array_reverse_split'. + */ +public class ArrayReverseSplit extends ScalarFunction implements PropagateNullable, HighOrderFunction { + public static final List<FunctionSignature> SIGNATURES = ImmutableList.of( + FunctionSignature.retArgType(0).args(ArrayType.of(AnyDataType.INSTANCE_WITHOUT_INDEX), + ArrayType.of(BooleanType.INSTANCE))); + + private ArrayReverseSplit(List<Expression> expressions) { + super("array_reverse_split", expressions); + } + + /** + * constructor with arguments. + */ + public ArrayReverseSplit(Expression arg0, Expression arg1) { + super("array_reverse_split", arg0, arg1); + } + + /** + * constructor with arguments. + * array_split(lambda, a1, ...) = array_split(a1, array_map(lambda, a1, ...)) + */ + public ArrayReverseSplit(Expression arg) { + super("array_reverse_split", arg.child(1).child(0), new ArrayMap(arg)); + if (!(arg instanceof Lambda)) { + throw new AnalysisException( + String.format("The 1st arg of %s must be lambda but is %s", getName(), arg)); + } + } + + @Override + public ArrayReverseSplit withChildren(List<Expression> children) { + return new ArrayReverseSplit(children.get(0), children.get(1)); + } + + @Override + public <R, C> R accept(ExpressionVisitor<R, C> visitor, C context) { + return visitor.visitArrayReverseSplit(this, context); + } + + @Override + public FunctionSignature computeSignature(FunctionSignature signature) { + FunctionSignature functionSignature = super.computeSignature(signature); + DataType argType0 = functionSignature.getArgType(0); + return signature.withReturnType(ArrayType.of(argType0)); Review Comment: why set return type here? u get wrong return type because ur signature is wrong -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
