platoneko commented on code in PR #35307: URL: https://github.com/apache/doris/pull/35307#discussion_r1618808399
########## be/src/io/fs/s3_obj_storage_client.cpp: ########## @@ -0,0 +1,348 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "io/fs/s3_obj_storage_client.h" + +#include <aws/core/client/AWSError.h> +#include <aws/core/http/HttpResponse.h> +#include <aws/core/http/URI.h> +#include <aws/core/utils/Array.h> +#include <aws/core/utils/HashingUtils.h> +#include <aws/core/utils/Outcome.h> +#include <aws/core/utils/memory/stl/AWSAllocator.h> +#include <aws/core/utils/memory/stl/AWSMap.h> +#include <aws/core/utils/memory/stl/AWSStreamFwd.h> +#include <aws/core/utils/memory/stl/AWSString.h> +#include <aws/core/utils/memory/stl/AWSStringStream.h> +#include <aws/core/utils/memory/stl/AWSVector.h> +#include <aws/core/utils/threading/Executor.h> +#include <aws/s3/S3Client.h> +#include <aws/s3/S3Errors.h> +#include <aws/s3/model/AbortMultipartUploadRequest.h> +#include <aws/s3/model/AbortMultipartUploadResult.h> +#include <aws/s3/model/CompleteMultipartUploadRequest.h> +#include <aws/s3/model/CompleteMultipartUploadResult.h> +#include <aws/s3/model/CompletedMultipartUpload.h> +#include <aws/s3/model/CompletedPart.h> +#include <aws/s3/model/CopyObjectRequest.h> +#include <aws/s3/model/CopyObjectResult.h> +#include <aws/s3/model/CreateMultipartUploadRequest.h> +#include <aws/s3/model/CreateMultipartUploadResult.h> +#include <aws/s3/model/Delete.h> +#include <aws/s3/model/DeleteObjectRequest.h> +#include <aws/s3/model/DeleteObjectResult.h> +#include <aws/s3/model/DeleteObjectsRequest.h> +#include <aws/s3/model/DeleteObjectsResult.h> +#include <aws/s3/model/Error.h> +#include <aws/s3/model/GetObjectRequest.h> +#include <aws/s3/model/GetObjectResult.h> +#include <aws/s3/model/HeadObjectRequest.h> +#include <aws/s3/model/HeadObjectResult.h> +#include <aws/s3/model/ListObjectsV2Request.h> +#include <aws/s3/model/ListObjectsV2Result.h> +#include <aws/s3/model/Object.h> +#include <aws/s3/model/ObjectIdentifier.h> +#include <aws/s3/model/PutObjectRequest.h> +#include <aws/s3/model/PutObjectResult.h> +#include <aws/s3/model/UploadPartRequest.h> +#include <aws/s3/model/UploadPartResult.h> +#include <bits/ranges_algo.h> + +#include "common/logging.h" +#include "common/status.h" +#include "common/sync_point.h" +#include "io/fs/err_utils.h" +#include "io/fs/s3_common.h" +#include "util/bvar_helper.h" + +namespace Aws::S3::Model { +class DeleteObjectRequest; +} // namespace Aws::S3::Model + +using Aws::S3::Model::CompletedPart; +using Aws::S3::Model::CompletedMultipartUpload; +using Aws::S3::Model::CompleteMultipartUploadRequest; +using Aws::S3::Model::CreateMultipartUploadRequest; +using Aws::S3::Model::UploadPartRequest; +using Aws::S3::Model::UploadPartOutcome; + +namespace doris::io { +using namespace Aws::S3::Model; +using Aws::S3::S3Client; + +ObjectStorageResponse S3ObjStorageClient::create_multipart_upload( + const ObjectStoragePathOptions& opts) { + CreateMultipartUploadRequest create_request; + create_request.WithBucket(opts.bucket).WithKey(opts.key); + create_request.SetContentType("application/octet-stream"); + + SCOPED_BVAR_LATENCY(s3_bvar::s3_multi_part_upload_latency); + auto outcome = SYNC_POINT_HOOK_RETURN_VALUE(_client->CreateMultipartUpload(create_request), + "s3_file_writer::create_multi_part_upload", + std::cref(create_request).get()); + SYNC_POINT_CALLBACK("s3_file_writer::_open", &outcome); + + if (outcome.IsSuccess()) { + return ObjectStorageResponse {.upload_id {outcome.GetResult().GetUploadId()}}; + } + return ObjectStorageResponse { + .status = s3fs_error( + outcome.GetError(), + fmt::format("failed to create multipart upload {} ", opts.path.native()))}; +} +ObjectStorageResponse S3ObjStorageClient::put_object(const ObjectStoragePathOptions& opts, Review Comment: 函数间换个行吧 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
