morrySnow commented on code in PR #31893:
URL: https://github.com/apache/doris/pull/31893#discussion_r1618161303
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -3543,6 +3546,26 @@ public LogicalPlan
visitShowCreateProcedure(ShowCreateProcedureContext ctx) {
return ParserUtils.withOrigin(ctx, () -> new
ShowCreateProcedureCommand(procedureName));
}
+ @Override
+ public LogicalPlan visitDropCatalogRecycleBin(DropCatalogRecycleBinContext
ctx) {
+ String idTypeStr = ctx.idType.getText().substring(1,
ctx.idType.getText().length() - 1);
+ IdType idType;
+ if (idTypeStr.equalsIgnoreCase("DbId")) {
Review Comment:
u should move this code block to enum type IdType. for example:
```
public static IdType valueOf(String idType) {
...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
