github-actions[bot] commented on code in PR #34929:
URL: https://github.com/apache/doris/pull/34929#discussion_r1618044977
##########
be/src/vec/runtime/vorc_transformer.cpp:
##########
@@ -156,83 +167,124 @@ Status VOrcTransformer::open() {
} catch (const std::exception& e) {
return Status::InternalError("failed to create writer: {}", e.what());
}
+ _writer->addUserMetadata("CreatedBy", doris::get_short_version());
return Status::OK();
}
-std::unique_ptr<orc::Type> VOrcTransformer::_build_orc_type(const
TypeDescriptor& type_descriptor) {
- std::pair<Status, std::unique_ptr<orc::Type>> result;
+std::unique_ptr<orc::Type> VOrcTransformer::_build_orc_type(
Review Comment:
warning: function '_build_orc_type' exceeds recommended size/complexity
thresholds [readability-function-size]
```cpp
std::unique_ptr<orc::Type> VOrcTransformer::_build_orc_type(
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/runtime/vorc_transformer.cpp:173:** 113 lines including
whitespace and comments (threshold 80)
```cpp
std::unique_ptr<orc::Type> VOrcTransformer::_build_orc_type(
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
