Re: [PR] [improvement](page builder) avoid allocating big memory in ctor and return error if allocate memory failed when init [doris]

[via GitHub]

github-actions[bot] commented on code in PR #35493:
URL: https://github.com/apache/doris/pull/35493#discussion_r1616554407


##########
be/src/olap/rowset/segment_v2/rle_page.h:
##########
@@ -54,23 +54,32 @@ template <FieldType Type>
 class RlePageBuilder : public PageBuilder {
 public:
     RlePageBuilder(const PageBuilderOptions& options)
-            : _options(options), _count(0), _finished(false), _bit_width(0), 
_rle_encoder(nullptr) {
-        switch (Type) {
-        case FieldType::OLAP_FIELD_TYPE_BOOL: {
-            _bit_width = 1;
-            break;
-        }
-        default: {
-            _bit_width = SIZE_OF_TYPE * 8;
-            break;
-        }
-        }
-        _rle_encoder = new RleEncoder<CppType>(&_buf, _bit_width);
-        reset();
-    }
+            : _options(options),
+              _count(0),
+              _finished(false),
+              _bit_width(0),
+              _rle_encoder(nullptr) {}

Review Comment:
   warning: member initializer for '_rle_encoder' is redundant 
[modernize-use-default-member-init]
   
   ```suggestion
                 {}
   ```
   



##########
be/src/olap/rowset/segment_v2/rle_page.h:
##########
@@ -54,23 +54,32 @@ template <FieldType Type>
 class RlePageBuilder : public PageBuilder {
 public:
     RlePageBuilder(const PageBuilderOptions& options)
-            : _options(options), _count(0), _finished(false), _bit_width(0), 
_rle_encoder(nullptr) {
-        switch (Type) {
-        case FieldType::OLAP_FIELD_TYPE_BOOL: {
-            _bit_width = 1;
-            break;
-        }
-        default: {
-            _bit_width = SIZE_OF_TYPE * 8;
-            break;
-        }
-        }
-        _rle_encoder = new RleEncoder<CppType>(&_buf, _bit_width);
-        reset();
-    }
+            : _options(options),
+              _count(0),
+              _finished(false),
+              _bit_width(0),
+              _rle_encoder(nullptr) {}

Review Comment:
   warning: member initializer for '_rle_encoder' is redundant 
[modernize-use-default-member-init]
   
   ```suggestion
                 {}
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org