morrySnow commented on code in PR #35348:
URL: https://github.com/apache/doris/pull/35348#discussion_r1615440768
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/MergeAggregate.java:
##########
@@ -108,10 +113,18 @@ private Plan
mergeAggProjectAgg(LogicalAggregate<LogicalProject<LogicalAggregate
.withChildren(innerAgg.children());
// construct upper project
- Map<SlotReference, Alias> childToAlias = project.getProjects().stream()
- .filter(expr -> (expr instanceof Alias) && (expr.child(0)
instanceof SlotReference))
- .collect(Collectors.toMap(alias -> (SlotReference)
alias.child(0), alias -> (Alias) alias));
- List<Expression> projectGroupBy =
ExpressionUtils.replace(replacedGroupBy, childToAlias);
+ Map<ExprId, NamedExpression> exprIdToNameExpressionMap = new
HashMap<>();
+ for (NamedExpression pro : project.getProjects()) {
+ exprIdToNameExpressionMap.put(pro.getExprId(), pro);
+ }
+ List<Expression> originOuterAggGroupBy =
outerAgg.getGroupByExpressions();
+ List<Expression> projectGroupBy = new ArrayList<>();
+ for (int i = 0; i < originOuterAggGroupBy.size(); i++) {
+ ExprId exprId = ((NamedExpression)
(originOuterAggGroupBy.get(i))).getExprId();
+ NamedExpression namedExpression =
exprIdToNameExpressionMap.get(exprId);
+ projectGroupBy.add(namedExpression);
+ }
+ // List<Expression> projectGroupBy =
ExpressionUtils.replace(replacedGroupBy, childToAlias);
Review Comment:
remove useless code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
