morrySnow commented on code in PR #35408:
URL: https://github.com/apache/doris/pull/35408#discussion_r1615393460
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/properties/FuncDeps.java:
##########
@@ -100,7 +100,11 @@ public Set<Set<Slot>> eliminateDeps(Set<Set<Slot>> slots) {
Set<Set<Slot>> minSlotSet = slots;
List<Set<Set<Slot>>> reduceSlotSets = new ArrayList<>();
reduceSlotSets.add(slots);
- while (!reduceSlotSets.isEmpty()) {
+ // To avoid memory usage due to multiple iterations,
+ // we set a maximum number of loop iterations.
+ int count = 0;
+ while (!reduceSlotSets.isEmpty() && count < 100) {
+ count += 1;
Review Comment:
could u add an example to explain why need more than 100 loops to reduce
slots?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
