github-actions[bot] commented on code in PR #35371:
URL: https://github.com/apache/doris/pull/35371#discussion_r1615039398
##########
be/src/runtime/runtime_predicate.cpp:
##########
@@ -17,35 +17,99 @@
#include "runtime/runtime_predicate.h"
-#include <stdint.h>
-
#include <memory>
#include "common/compiler_util.h" // IWYU pragma: keep
+#include "common/exception.h"
+#include "common/status.h"
#include "olap/accept_null_predicate.h"
#include "olap/column_predicate.h"
#include "olap/predicate_creator.h"
namespace doris::vectorized {
-Status RuntimePredicate::init(PrimitiveType type, bool nulls_first, bool
is_asc,
- const std::string& col_name) {
- std::unique_lock<std::shared_mutex> wlock(_rwlock);
+RuntimePredicate::RuntimePredicate(const TTopnFilterDesc& desc)
+ : _nulls_first(desc.null_first), _is_asc(desc.is_asc) {
+ DCHECK(!desc.target_node_id_to_target_expr.empty());
+ for (auto p : desc.target_node_id_to_target_expr) {
+ _contexts[p.first].expr = p.second;
+ }
- if (_inited) {
- return Status::OK();
+ PrimitiveType type =
thrift_to_type(desc.target_node_id_to_target_expr.begin()
+ ->second.nodes[0]
+ .type.types[0]
+ .scalar_type.type);
+ if (!_init(type)) {
+ std::stringstream ss;
+
desc.target_node_id_to_target_expr.begin()->second.nodes[0].printTo(ss);
+ throw Exception(ErrorCode::INTERNAL_ERROR, "meet invalid type,
type={}, expr={}", int(type),
+ ss.str());
}
- _nulls_first = nulls_first;
- _is_asc = is_asc;
// For ASC sort, create runtime predicate col_name <= max_top_value
// since values that > min_top_value are large than any value in current
topn values
// For DESC sort, create runtime predicate col_name >= min_top_value
// since values that < min_top_value are less than any value in current
topn values
- _pred_constructor = is_asc ? create_comparison_predicate<PredicateType::LE>
- :
create_comparison_predicate<PredicateType::GE>;
- _col_name = col_name;
+ _pred_constructor = _is_asc ?
create_comparison_predicate<PredicateType::LE>
+ :
create_comparison_predicate<PredicateType::GE>;
+}
+
+void RuntimePredicate::init_target(
+ int32_t target_node_id, phmap::flat_hash_map<int, SlotDescriptor*>
slot_id_to_slot_desc) {
+ std::unique_lock<std::shared_mutex> wlock(_rwlock);
+ check_target_node_id(target_node_id);
+ if (target_is_slot(target_node_id)) {
+ _contexts[target_node_id].col_name =
+
slot_id_to_slot_desc[get_texpr(target_node_id).nodes[0].slot_ref.slot_id]
+ ->col_name();
+ }
+ _detected_target = true;
+}
+template <PrimitiveType type>
+std::string get_normal_value(const Field& field) {
+ using ValueType = typename PrimitiveTypeTraits<type>::CppType;
+ return cast_to_string<type, ValueType>(field.get<ValueType>(), 0);
+}
+
+std::string get_date_value(const Field& field) {
+ using ValueType = typename PrimitiveTypeTraits<TYPE_DATE>::CppType;
+ ValueType value;
+ Int64 v = field.get<Int64>();
+ auto* p = (VecDateTimeValue*)&v;
+ value.from_olap_date(p->to_olap_date());
+ value.cast_to_date();
+ return cast_to_string<TYPE_DATE, ValueType>(value, 0);
+}
+
+std::string get_datetime_value(const Field& field) {
+ using ValueType = typename PrimitiveTypeTraits<TYPE_DATETIME>::CppType;
+ ValueType value;
+ Int64 v = field.get<Int64>();
+ auto* p = (VecDateTimeValue*)&v;
+ value.from_olap_datetime(p->to_olap_datetime());
+ value.to_datetime();
+ return cast_to_string<TYPE_DATETIME, ValueType>(value, 0);
+}
+
+std::string get_decimalv2_value(const Field& field) {
+ // can NOT use PrimitiveTypeTraits<TYPE_DECIMALV2>::CppType since
+ // it is DecimalV2Value and Decimal128V2 can not convert to it implicitly
+ using ValueType = Decimal128V2::NativeType;
+ auto v = field.get<DecimalField<Decimal128V2>>();
+ // use TYPE_DECIMAL128I instead of TYPE_DECIMALV2 since v.get_scale()
+ // is always 9 for DECIMALV2
+ return cast_to_string<TYPE_DECIMAL128I, ValueType>(v.get_value(),
v.get_scale());
+}
+
+template <PrimitiveType type>
+std::string get_decimal_value(const Field& field) {
+ using ValueType = typename PrimitiveTypeTraits<type>::CppType;
+ auto v = field.get<DecimalField<ValueType>>();
+ return cast_to_string<type, ValueType>(v.get_value(), v.get_scale());
+}
+
+bool RuntimePredicate::_init(PrimitiveType type) {
Review Comment:
warning: function '_init' exceeds recommended size/complexity thresholds
[readability-function-size]
```cpp
bool RuntimePredicate::_init(PrimitiveType type) {
^
```
<details>
<summary>Additional context</summary>
**be/src/runtime/runtime_predicate.cpp:111:** 82 lines including whitespace
and comments (threshold 80)
```cpp
bool RuntimePredicate::_init(PrimitiveType type) {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
