yiguolei commented on code in PR #35329: URL: https://github.com/apache/doris/pull/35329#discussion_r1614688093
########## be/src/pipeline/exec/exchange_sink_operator.cpp: ########## @@ -155,12 +155,17 @@ Status ExchangeSinkLocalState::open(RuntimeState* state) { size_t dep_id = 0; for (auto* channel : channels) { if (channel->is_local()) { - _local_channels_dependency.push_back(channel->get_local_channel_dependency()); Review Comment: why should we extract this dependency dynamically? The channel is inited during prepare. We should extract these dependency during open? I think we should extract it during prepare stage and then we could avoid such problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org