morningman commented on pull request #7951: URL: https://github.com/apache/incubator-doris/pull/7951#issuecomment-1031108305
Hi @dataroaring , thanks for you contribution. This is a huge PR, I think it is better to discuss about it, or at least add document to explain how it works and how to use it. Also take care about the license header, and if it is copied from other project, better announce it after the license header. For example: https://github.com/apache/incubator-doris/blob/8207883319b0ab4b5fae709098c65867298b4118/be/src/vec/core/block.cpp#L1-L20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
