englefly commented on code in PR #35074:
URL: https://github.com/apache/doris/pull/35074#discussion_r1611330036
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/AdjustNullable.java:
##########
@@ -165,45 +165,52 @@ public Plan visitLogicalRepeat(LogicalRepeat<? extends
Plan> repeat, Map<ExprId,
@Override
public Plan visitLogicalSetOperation(LogicalSetOperation setOperation,
Map<ExprId, Slot> replaceMap) {
setOperation = (LogicalSetOperation) super.visit(setOperation,
replaceMap);
- if (setOperation.children().isEmpty()) {
- return setOperation;
- }
- List<Boolean> inputNullable =
setOperation.child(0).getOutput().stream()
- .map(ExpressionTrait::nullable).collect(Collectors.toList());
ImmutableList.Builder<List<SlotReference>> newChildrenOutputs =
ImmutableList.builder();
- for (int i = 0; i < setOperation.arity(); i++) {
- List<Slot> childOutput = setOperation.child(i).getOutput();
- List<SlotReference> setChildOutput =
setOperation.getRegularChildOutput(i);
- ImmutableList.Builder<SlotReference> newChildOutputs =
ImmutableList.builder();
- for (int j = 0; j < setChildOutput.size(); j++) {
- for (Slot slot : childOutput) {
- if
(slot.getExprId().equals(setChildOutput.get(j).getExprId())) {
- inputNullable.set(j, slot.nullable() ||
inputNullable.get(j));
- newChildOutputs.add((SlotReference) slot);
- break;
+ List<Boolean> inputNullable = null;
+ if (!setOperation.children().isEmpty()) {
+ inputNullable = setOperation.child(0).getOutput().stream()
+
.map(ExpressionTrait::nullable).collect(Collectors.toList());
+ for (int i = 0; i < setOperation.arity(); i++) {
+ List<Slot> childOutput = setOperation.child(i).getOutput();
+ List<SlotReference> setChildOutput =
setOperation.getRegularChildOutput(i);
+ ImmutableList.Builder<SlotReference> newChildOutputs =
ImmutableList.builder();
+ for (int j = 0; j < setChildOutput.size(); j++) {
+ for (Slot slot : childOutput) {
+ if
(slot.getExprId().equals(setChildOutput.get(j).getExprId())) {
+ inputNullable.set(j, slot.nullable() ||
inputNullable.get(j));
+ newChildOutputs.add((SlotReference) slot);
+ break;
+ }
}
}
+ newChildrenOutputs.add(newChildOutputs.build());
}
- newChildrenOutputs.add(newChildOutputs.build());
}
if (setOperation instanceof LogicalUnion) {
LogicalUnion logicalUnion = (LogicalUnion) setOperation;
+ int consExprListSize = logicalUnion.getConstantExprsList().size();
+ if (consExprListSize > 0 && inputNullable == null) {
Review Comment:
!logicalUnion.getConstantExprsList().isEmpty() &&
!setOperation.children().isEmpty()
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/AdjustNullable.java:
##########
@@ -165,45 +165,52 @@ public Plan visitLogicalRepeat(LogicalRepeat<? extends
Plan> repeat, Map<ExprId,
@Override
public Plan visitLogicalSetOperation(LogicalSetOperation setOperation,
Map<ExprId, Slot> replaceMap) {
setOperation = (LogicalSetOperation) super.visit(setOperation,
replaceMap);
- if (setOperation.children().isEmpty()) {
- return setOperation;
- }
- List<Boolean> inputNullable =
setOperation.child(0).getOutput().stream()
- .map(ExpressionTrait::nullable).collect(Collectors.toList());
ImmutableList.Builder<List<SlotReference>> newChildrenOutputs =
ImmutableList.builder();
- for (int i = 0; i < setOperation.arity(); i++) {
- List<Slot> childOutput = setOperation.child(i).getOutput();
- List<SlotReference> setChildOutput =
setOperation.getRegularChildOutput(i);
- ImmutableList.Builder<SlotReference> newChildOutputs =
ImmutableList.builder();
- for (int j = 0; j < setChildOutput.size(); j++) {
- for (Slot slot : childOutput) {
- if
(slot.getExprId().equals(setChildOutput.get(j).getExprId())) {
- inputNullable.set(j, slot.nullable() ||
inputNullable.get(j));
- newChildOutputs.add((SlotReference) slot);
- break;
+ List<Boolean> inputNullable = null;
+ if (!setOperation.children().isEmpty()) {
+ inputNullable = setOperation.child(0).getOutput().stream()
+
.map(ExpressionTrait::nullable).collect(Collectors.toList());
+ for (int i = 0; i < setOperation.arity(); i++) {
+ List<Slot> childOutput = setOperation.child(i).getOutput();
+ List<SlotReference> setChildOutput =
setOperation.getRegularChildOutput(i);
+ ImmutableList.Builder<SlotReference> newChildOutputs =
ImmutableList.builder();
+ for (int j = 0; j < setChildOutput.size(); j++) {
+ for (Slot slot : childOutput) {
+ if
(slot.getExprId().equals(setChildOutput.get(j).getExprId())) {
+ inputNullable.set(j, slot.nullable() ||
inputNullable.get(j));
+ newChildOutputs.add((SlotReference) slot);
+ break;
+ }
}
}
+ newChildrenOutputs.add(newChildOutputs.build());
}
- newChildrenOutputs.add(newChildOutputs.build());
}
if (setOperation instanceof LogicalUnion) {
LogicalUnion logicalUnion = (LogicalUnion) setOperation;
+ int consExprListSize = logicalUnion.getConstantExprsList().size();
+ if (consExprListSize > 0 && inputNullable == null) {
+ int outputSize =
logicalUnion.getConstantExprsList().get(0).size();
+ inputNullable = Lists.newArrayListWithCapacity(outputSize);
+ for (int i = 0; i < outputSize; i++) {
+ inputNullable.add(false);
+ }
+ }
for (List<NamedExpression> constantExprs :
logicalUnion.getConstantExprsList()) {
for (int j = 0; j < constantExprs.size(); j++) {
- if (constantExprs.get(j).nullable()) {
- inputNullable.set(j, true);
- }
+ inputNullable.set(j, inputNullable.get(j) ||
constantExprs.get(j).nullable());
}
}
}
+ if (inputNullable == null) {
Review Comment:
logicalUnion.getConstantExprsList().isEmpty() &&
setOperation.children().isEmpty()
=> inputNullable == null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
