Re: [PR] [improve](exchange) the sink could eos early when all queues have enough rows [doris]

[via GitHub]

github-actions[bot] commented on code in PR #34541:
URL: https://github.com/apache/doris/pull/34541#discussion_r1609624459


##########
be/src/vec/runtime/vdata_stream_recvr.cpp:
##########
@@ -418,12 +425,29 @@ Status VDataStreamRecvr::add_block(const PBlock& pblock, 
int sender_id, int be_n
                                    int64_t packet_seq, 
::google::protobuf::Closure** done) {
     SCOPED_ATTACH_TASK_WITH_ID(_query_mem_tracker, _query_id);
     int use_sender_id = _is_merging ? sender_id : 0;
-    return _sender_queues[use_sender_id]->add_block(pblock, be_number, 
packet_seq, done);
+    int64_t current_pblock_rows = 0;
+    RETURN_IF_ERROR(_sender_queues[use_sender_id]->add_block(pblock, 
be_number, packet_seq, done,
+                                                             
&current_pblock_rows));
+    _queue_total_rows[use_sender_id] = _queue_total_rows[use_sender_id] + 
current_pblock_rows;
+    return Status::OK();
 }
 
-void VDataStreamRecvr::add_block(Block* block, int sender_id, bool use_move) {
+int64_t VDataStreamRecvr::add_block(Block* block, int sender_id, bool 
use_move) {

Review Comment:
   warning: method 'add_block' can be made const 
[readability-make-member-function-const]
   
   ```suggestion
   int64_t VDataStreamRecvr::add_block(Block* block, int sender_id, bool 
use_move) const {
   ```
   
   be/src/vec/runtime/vdata_stream_recvr.h:87:
   ```diff
   -     int64_t add_block(Block* block, int sender_id, bool use_move);
   +     int64_t add_block(Block* block, int sender_id, bool use_move) const;
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org