morrySnow commented on code in PR #35147:
URL: https://github.com/apache/doris/pull/35147#discussion_r1608245934
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/cost/CostModelV1.java:
##########
@@ -141,7 +142,8 @@ public Cost visitPhysicalFileScan(PhysicalFileScan
physicalFileScan, PlanContext
@Override
public Cost visitPhysicalProject(PhysicalProject<? extends Plan>
physicalProject, PlanContext context) {
- return CostV1.ofCpu(context.getSessionVariable(), 1);
+ long exprCount = physicalProject.getProjects().stream().filter(proj ->
!(proj instanceof Slot)).count();
Review Comment:
should check output.size() is same with child's output.size().
otherwise, we may lose some column prune project when select best cost plan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
