github-actions[bot] commented on code in PR #34929: URL: https://github.com/apache/doris/pull/34929#discussion_r1606261385
########## be/src/vec/exec/format/table/iceberg/partition_spec.cpp: ########## @@ -0,0 +1,71 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "vec/exec/format/table/iceberg/partition_spec.h" + +#include <memory> +#include <string> +#include <vector> + +#include "vec/exec/format/table/iceberg/schema.h" +#include "vec/exec/format/table/iceberg/struct_like.h" + +namespace doris { +namespace iceberg { Review Comment: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] ```suggestion namespace doris::iceberg { ``` be/src/vec/exec/format/table/iceberg/partition_spec.cpp:69: ```diff - } // namespace iceberg - } // namespace doris + } // namespace doris ``` ########## be/src/vec/exec/format/table/iceberg/partition_spec.h: ########## @@ -0,0 +1,95 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <atomic> +#include <memory> + +namespace doris { +namespace iceberg { + +class StructLike; +class Schema; + +class PartitionField { +public: + PartitionField(int sourceId, int fieldId, std::string name, std::string transform); + + int source_id() const { return _source_id; } + + int field_id() const { return _field_id; } + + const std::string& name() const { return _name; } + + const std::string& transform() const { return _transform; } + +private: + int _source_id; + int _field_id; + std::string _name; + std::string _transform; +}; + +class PartitionSpec { +public: + class Builder { + public: + Builder(std::shared_ptr<Schema> schema); + + ~Builder() = default; + + Builder& with_spec_id(int new_spec_id); + + Builder& add(int sourceId, int fieldId, std::string name, std::string transform); + + Builder& add(int sourceId, std::string name, std::string transform); + + std::unique_ptr<PartitionSpec> build(); + + private: + int next_field_id() { return ++_last_assigned_field_id; } + + private: + std::shared_ptr<Schema> _schema; + std::vector<PartitionField> _fields; + int _spec_id; + std::atomic<int> _last_assigned_field_id; + }; + + PartitionSpec(std::shared_ptr<Schema> schema, int spec_id, std::vector<PartitionField> fields, + int last_assigned_field_id); + + const Schema& schema() const { return *_schema; } + + int spec_id() { return _spec_id; } Review Comment: warning: method 'spec_id' can be made const [readability-make-member-function-const] ```suggestion int spec_id() const { return _spec_id; } ``` ########## be/src/vec/exec/format/table/iceberg/schema.h: ########## @@ -0,0 +1,55 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include "vec/exec/format/table/iceberg/types.h" + +namespace doris { +namespace iceberg { Review Comment: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] ```suggestion namespace doris::iceberg { ``` be/src/vec/exec/format/table/iceberg/schema.h:53: ```diff - } // namespace iceberg - } // namespace doris + } // namespace doris ``` ########## be/src/vec/exec/format/table/iceberg/partition_spec.h: ########## @@ -0,0 +1,95 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <atomic> +#include <memory> + +namespace doris { +namespace iceberg { Review Comment: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] ```suggestion namespace doris::iceberg { ``` be/src/vec/exec/format/table/iceberg/partition_spec.h:93: ```diff - } // namespace iceberg - } // namespace doris + } // namespace doris ``` ########## be/src/vec/exec/format/table/iceberg/partition_spec.h: ########## @@ -0,0 +1,95 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <atomic> +#include <memory> + +namespace doris { +namespace iceberg { + +class StructLike; +class Schema; + +class PartitionField { +public: + PartitionField(int sourceId, int fieldId, std::string name, std::string transform); + + int source_id() const { return _source_id; } + + int field_id() const { return _field_id; } + + const std::string& name() const { return _name; } + + const std::string& transform() const { return _transform; } + +private: + int _source_id; + int _field_id; + std::string _name; + std::string _transform; +}; + +class PartitionSpec { +public: + class Builder { + public: + Builder(std::shared_ptr<Schema> schema); + + ~Builder() = default; + + Builder& with_spec_id(int new_spec_id); + + Builder& add(int sourceId, int fieldId, std::string name, std::string transform); + + Builder& add(int sourceId, std::string name, std::string transform); + + std::unique_ptr<PartitionSpec> build(); + + private: + int next_field_id() { return ++_last_assigned_field_id; } + + private: Review Comment: warning: redundant access specifier has the same accessibility as the previous access specifier [readability-redundant-access-specifiers] ```suggestion ``` <details> <summary>Additional context</summary> **be/src/vec/exec/format/table/iceberg/partition_spec.h:63:** previously declared here ```cpp private: ^ ``` </details> ########## be/src/vec/exec/format/table/iceberg/partition_spec.h: ########## @@ -0,0 +1,95 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <atomic> +#include <memory> + +namespace doris { +namespace iceberg { + +class StructLike; +class Schema; + +class PartitionField { +public: + PartitionField(int sourceId, int fieldId, std::string name, std::string transform); + + int source_id() const { return _source_id; } + + int field_id() const { return _field_id; } + + const std::string& name() const { return _name; } + + const std::string& transform() const { return _transform; } + +private: + int _source_id; + int _field_id; + std::string _name; + std::string _transform; +}; + +class PartitionSpec { +public: + class Builder { + public: + Builder(std::shared_ptr<Schema> schema); + + ~Builder() = default; + + Builder& with_spec_id(int new_spec_id); + + Builder& add(int sourceId, int fieldId, std::string name, std::string transform); + + Builder& add(int sourceId, std::string name, std::string transform); + + std::unique_ptr<PartitionSpec> build(); + + private: + int next_field_id() { return ++_last_assigned_field_id; } + + private: + std::shared_ptr<Schema> _schema; + std::vector<PartitionField> _fields; + int _spec_id; + std::atomic<int> _last_assigned_field_id; + }; + + PartitionSpec(std::shared_ptr<Schema> schema, int spec_id, std::vector<PartitionField> fields, + int last_assigned_field_id); + + const Schema& schema() const { return *_schema; } + + int spec_id() { return _spec_id; } + + const std::vector<PartitionField>& fields() const { return _fields; } + + int last_assigned_field_id() const { return _last_assigned_field_id; } + +private: + // IDs for partition fields start at 1000 + static constexpr int PARTITION_DATA_ID_START = 1000; + std::shared_ptr<Schema> _schema; + int _spec_id; + std::vector<PartitionField> _fields; Review Comment: warning: no template named 'vector' in namespace 'std' [clang-diagnostic-error] ```cpp std::vector<PartitionField> _fields; ^ ``` ########## be/src/vec/exec/format/table/iceberg/partition_spec.h: ########## @@ -0,0 +1,95 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <atomic> +#include <memory> + +namespace doris { +namespace iceberg { + +class StructLike; +class Schema; + +class PartitionField { +public: + PartitionField(int sourceId, int fieldId, std::string name, std::string transform); + + int source_id() const { return _source_id; } + + int field_id() const { return _field_id; } + + const std::string& name() const { return _name; } + + const std::string& transform() const { return _transform; } + +private: + int _source_id; + int _field_id; + std::string _name; + std::string _transform; +}; + +class PartitionSpec { +public: + class Builder { + public: + Builder(std::shared_ptr<Schema> schema); + + ~Builder() = default; + + Builder& with_spec_id(int new_spec_id); + + Builder& add(int sourceId, int fieldId, std::string name, std::string transform); + + Builder& add(int sourceId, std::string name, std::string transform); + + std::unique_ptr<PartitionSpec> build(); + + private: + int next_field_id() { return ++_last_assigned_field_id; } + + private: + std::shared_ptr<Schema> _schema; + std::vector<PartitionField> _fields; Review Comment: warning: no template named 'vector' in namespace 'std' [clang-diagnostic-error] ```cpp std::vector<PartitionField> _fields; ^ ``` ########## be/src/vec/exec/format/table/iceberg/partition_spec.h: ########## @@ -0,0 +1,95 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <atomic> +#include <memory> + +namespace doris { +namespace iceberg { + +class StructLike; +class Schema; + +class PartitionField { +public: + PartitionField(int sourceId, int fieldId, std::string name, std::string transform); + + int source_id() const { return _source_id; } + + int field_id() const { return _field_id; } + + const std::string& name() const { return _name; } + + const std::string& transform() const { return _transform; } + +private: + int _source_id; + int _field_id; + std::string _name; + std::string _transform; +}; + +class PartitionSpec { +public: + class Builder { + public: + Builder(std::shared_ptr<Schema> schema); + + ~Builder() = default; + + Builder& with_spec_id(int new_spec_id); + + Builder& add(int sourceId, int fieldId, std::string name, std::string transform); + + Builder& add(int sourceId, std::string name, std::string transform); + + std::unique_ptr<PartitionSpec> build(); + + private: + int next_field_id() { return ++_last_assigned_field_id; } + + private: + std::shared_ptr<Schema> _schema; + std::vector<PartitionField> _fields; + int _spec_id; + std::atomic<int> _last_assigned_field_id; + }; + + PartitionSpec(std::shared_ptr<Schema> schema, int spec_id, std::vector<PartitionField> fields, + int last_assigned_field_id); + + const Schema& schema() const { return *_schema; } + + int spec_id() { return _spec_id; } + + const std::vector<PartitionField>& fields() const { return _fields; } Review Comment: warning: no template named 'vector' in namespace 'std' [clang-diagnostic-error] ```cpp const std::vector<PartitionField>& fields() const { return _fields; } ^ ``` ########## be/src/vec/exec/format/table/iceberg/partition_spec_parser.cpp: ########## @@ -0,0 +1,67 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "vec/exec/format/table/iceberg/partition_spec_parser.h" + +#include <rapidjson/error/en.h> + +#include "common/exception.h" + +namespace doris { +namespace iceberg { Review Comment: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] ```suggestion namespace doris::iceberg { ``` be/src/vec/exec/format/table/iceberg/partition_spec_parser.cpp:65: ```diff - } // namespace iceberg - } // namespace doris + } // namespace doris ``` ########## be/src/vec/exec/format/table/iceberg/schema_parser.h: ########## @@ -0,0 +1,73 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +//#include <rapidjson/document.h> +// +//#include <iostream> +//#include <memory> +//#include <string> +//#include <unordered_map> +//#include <unordered_set> +//#include <vector> + +namespace doris { +namespace iceberg { + +// Forward declarations +class Type; +class StructType; +class ListType; +class MapType; +class NestedField; +class Schema; + +class SchemaParser { +public: + static const char* SCHEMA_ID; + static const char* IDENTIFIER_FIELD_IDS; + static const char* TYPE; + static const char* STRUCT; + static const char* LIST; + static const char* MAP; + static const char* FIELDS; + static const char* ELEMENT; + static const char* KEY; + static const char* VALUE; + static const char* DOC; + static const char* NAME; + static const char* ID; + static const char* ELEMENT_ID; + static const char* KEY_ID; + static const char* VALUE_ID; + static const char* REQUIRED; + static const char* ELEMENT_REQUIRED; + static const char* VALUE_REQUIRED; + + static std::unique_ptr<Schema> from_json(const std::string& json); Review Comment: warning: use of undeclared identifier 'std' [clang-diagnostic-error] ```cpp static std::unique_ptr<Schema> from_json(const std::string& json); ^ ``` ########## be/src/vec/exec/format/table/iceberg/partition_spec.h: ########## @@ -0,0 +1,95 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <atomic> +#include <memory> + +namespace doris { +namespace iceberg { + +class StructLike; +class Schema; + +class PartitionField { +public: + PartitionField(int sourceId, int fieldId, std::string name, std::string transform); + + int source_id() const { return _source_id; } + + int field_id() const { return _field_id; } + + const std::string& name() const { return _name; } + + const std::string& transform() const { return _transform; } + +private: + int _source_id; + int _field_id; + std::string _name; + std::string _transform; +}; + +class PartitionSpec { +public: + class Builder { + public: + Builder(std::shared_ptr<Schema> schema); + + ~Builder() = default; + + Builder& with_spec_id(int new_spec_id); + + Builder& add(int sourceId, int fieldId, std::string name, std::string transform); + + Builder& add(int sourceId, std::string name, std::string transform); + + std::unique_ptr<PartitionSpec> build(); + + private: + int next_field_id() { return ++_last_assigned_field_id; } + + private: + std::shared_ptr<Schema> _schema; + std::vector<PartitionField> _fields; + int _spec_id; + std::atomic<int> _last_assigned_field_id; + }; + + PartitionSpec(std::shared_ptr<Schema> schema, int spec_id, std::vector<PartitionField> fields, Review Comment: warning: no template named 'vector' in namespace 'std' [clang-diagnostic-error] ```cpp PartitionSpec(std::shared_ptr<Schema> schema, int spec_id, std::vector<PartitionField> fields, ^ ``` ########## be/src/vec/exec/format/table/iceberg/schema_parser.h: ########## @@ -0,0 +1,73 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +//#include <rapidjson/document.h> +// +//#include <iostream> +//#include <memory> +//#include <string> +//#include <unordered_map> +//#include <unordered_set> +//#include <vector> + +namespace doris { +namespace iceberg { Review Comment: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] ```suggestion namespace doris::iceberg { ``` be/src/vec/exec/format/table/iceberg/schema_parser.h:71: ```diff - } // namespace iceberg - } // namespace doris + } // namespace doris ``` ########## be/src/vec/exec/format/table/iceberg/partition_spec_parser.h: ########## @@ -0,0 +1,56 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +//#include <rapidjson/document.h> +//#include <rapidjson/error/en.h> +// +//#include <unordered_set> +// +//#include "common/exception.h" +//#include "vec/exec/format/table/iceberg/schema.h" +#include <rapidjson/document.h> Review Comment: warning: 'rapidjson/document.h' file not found [clang-diagnostic-error] ```cpp #include <rapidjson/document.h> ^ ``` ########## be/src/vec/exec/format/table/iceberg/partition_spec_parser.h: ########## @@ -0,0 +1,56 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +//#include <rapidjson/document.h> +//#include <rapidjson/error/en.h> +// +//#include <unordered_set> +// +//#include "common/exception.h" +//#include "vec/exec/format/table/iceberg/schema.h" +#include <rapidjson/document.h> + +#include "vec/exec/format/table/iceberg/unbound_partition_spec.h" + +namespace doris { +namespace iceberg { Review Comment: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] ```suggestion namespace doris::iceberg { ``` be/src/vec/exec/format/table/iceberg/partition_spec_parser.h:54: ```diff - } // namespace iceberg - } // namespace doris + } // namespace doris ``` ########## be/src/vec/exec/format/table/iceberg/schema_parser.cpp: ########## @@ -0,0 +1,163 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "vec/exec/format/table/iceberg/schema_parser.h" + +#include <rapidjson/document.h> +#include <rapidjson/error/en.h> + +#include <optional> +#include <unordered_set> + +#include "vec/exec/format/table/iceberg/schema.h" +#include "vec/exec/format/table/iceberg/types.h" + +namespace doris { +namespace iceberg { Review Comment: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] ```suggestion namespace doris::iceberg { ``` be/src/vec/exec/format/table/iceberg/schema_parser.cpp:161: ```diff - } // namespace iceberg - } // namespace doris + } // namespace doris ``` ########## be/src/vec/exec/format/table/iceberg/schema.cpp: ########## @@ -0,0 +1,53 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "vec/exec/format/table/iceberg/schema.h" + +namespace doris { +namespace iceberg { Review Comment: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] ```suggestion namespace doris::iceberg { ``` be/src/vec/exec/format/table/iceberg/schema.cpp:51: ```diff - } // namespace iceberg - } // namespace doris + } // namespace doris ``` ########## be/src/vec/exec/format/table/iceberg/schema_parser.cpp: ########## @@ -0,0 +1,163 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "vec/exec/format/table/iceberg/schema_parser.h" + +#include <rapidjson/document.h> Review Comment: warning: 'rapidjson/document.h' file not found [clang-diagnostic-error] ```cpp #include <rapidjson/document.h> ^ ``` ########## be/src/vec/exec/format/table/iceberg/schema_parser.h: ########## @@ -0,0 +1,73 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +//#include <rapidjson/document.h> +// +//#include <iostream> +//#include <memory> +//#include <string> +//#include <unordered_map> +//#include <unordered_set> +//#include <vector> + +namespace doris { +namespace iceberg { + +// Forward declarations +class Type; +class StructType; +class ListType; +class MapType; +class NestedField; +class Schema; + +class SchemaParser { +public: + static const char* SCHEMA_ID; + static const char* IDENTIFIER_FIELD_IDS; + static const char* TYPE; + static const char* STRUCT; + static const char* LIST; + static const char* MAP; + static const char* FIELDS; + static const char* ELEMENT; + static const char* KEY; + static const char* VALUE; + static const char* DOC; + static const char* NAME; + static const char* ID; + static const char* ELEMENT_ID; + static const char* KEY_ID; + static const char* VALUE_ID; + static const char* REQUIRED; + static const char* ELEMENT_REQUIRED; + static const char* VALUE_REQUIRED; + + static std::unique_ptr<Schema> from_json(const std::string& json); + +private: + static std::unique_ptr<Type> _type_from_json(const rapidjson::Value& value); + static std::unique_ptr<StructType> _struct_from_json(const rapidjson::Value& value); + static std::unique_ptr<ListType> _list_from_json(const rapidjson::Value& value); Review Comment: warning: use of undeclared identifier 'std' [clang-diagnostic-error] ```cpp static std::unique_ptr<ListType> _list_from_json(const rapidjson::Value& value); ^ ``` ########## be/src/vec/exec/format/table/iceberg/schema_parser.h: ########## @@ -0,0 +1,73 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +//#include <rapidjson/document.h> +// +//#include <iostream> +//#include <memory> +//#include <string> +//#include <unordered_map> +//#include <unordered_set> +//#include <vector> + +namespace doris { +namespace iceberg { + +// Forward declarations +class Type; +class StructType; +class ListType; +class MapType; +class NestedField; +class Schema; + +class SchemaParser { +public: + static const char* SCHEMA_ID; + static const char* IDENTIFIER_FIELD_IDS; + static const char* TYPE; + static const char* STRUCT; + static const char* LIST; + static const char* MAP; + static const char* FIELDS; + static const char* ELEMENT; + static const char* KEY; + static const char* VALUE; + static const char* DOC; + static const char* NAME; + static const char* ID; + static const char* ELEMENT_ID; + static const char* KEY_ID; + static const char* VALUE_ID; + static const char* REQUIRED; + static const char* ELEMENT_REQUIRED; + static const char* VALUE_REQUIRED; + + static std::unique_ptr<Schema> from_json(const std::string& json); + +private: + static std::unique_ptr<Type> _type_from_json(const rapidjson::Value& value); Review Comment: warning: use of undeclared identifier 'std' [clang-diagnostic-error] ```cpp static std::unique_ptr<Type> _type_from_json(const rapidjson::Value& value); ^ ``` ########## be/src/vec/exec/format/table/iceberg/schema_parser.h: ########## @@ -0,0 +1,73 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +//#include <rapidjson/document.h> +// +//#include <iostream> +//#include <memory> +//#include <string> +//#include <unordered_map> +//#include <unordered_set> +//#include <vector> + +namespace doris { +namespace iceberg { + +// Forward declarations +class Type; +class StructType; +class ListType; +class MapType; +class NestedField; +class Schema; + +class SchemaParser { +public: + static const char* SCHEMA_ID; + static const char* IDENTIFIER_FIELD_IDS; + static const char* TYPE; + static const char* STRUCT; + static const char* LIST; + static const char* MAP; + static const char* FIELDS; + static const char* ELEMENT; + static const char* KEY; + static const char* VALUE; + static const char* DOC; + static const char* NAME; + static const char* ID; + static const char* ELEMENT_ID; + static const char* KEY_ID; + static const char* VALUE_ID; + static const char* REQUIRED; + static const char* ELEMENT_REQUIRED; + static const char* VALUE_REQUIRED; + + static std::unique_ptr<Schema> from_json(const std::string& json); + +private: + static std::unique_ptr<Type> _type_from_json(const rapidjson::Value& value); Review Comment: warning: use of undeclared identifier 'rapidjson' [clang-diagnostic-error] ```cpp static std::unique_ptr<Type> _type_from_json(const rapidjson::Value& value); ^ ``` ########## be/src/vec/exec/format/table/iceberg/schema_parser.h: ########## @@ -0,0 +1,73 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +//#include <rapidjson/document.h> +// +//#include <iostream> +//#include <memory> +//#include <string> +//#include <unordered_map> +//#include <unordered_set> +//#include <vector> + +namespace doris { +namespace iceberg { + +// Forward declarations +class Type; +class StructType; +class ListType; +class MapType; +class NestedField; +class Schema; + +class SchemaParser { +public: + static const char* SCHEMA_ID; + static const char* IDENTIFIER_FIELD_IDS; + static const char* TYPE; + static const char* STRUCT; + static const char* LIST; + static const char* MAP; + static const char* FIELDS; + static const char* ELEMENT; + static const char* KEY; + static const char* VALUE; + static const char* DOC; + static const char* NAME; + static const char* ID; + static const char* ELEMENT_ID; + static const char* KEY_ID; + static const char* VALUE_ID; + static const char* REQUIRED; + static const char* ELEMENT_REQUIRED; + static const char* VALUE_REQUIRED; + + static std::unique_ptr<Schema> from_json(const std::string& json); Review Comment: warning: use of undeclared identifier 'std' [clang-diagnostic-error] ```cpp static std::unique_ptr<Schema> from_json(const std::string& json); ^ ``` ########## be/src/vec/exec/format/table/iceberg/schema_parser.h: ########## @@ -0,0 +1,73 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +//#include <rapidjson/document.h> +// +//#include <iostream> +//#include <memory> +//#include <string> +//#include <unordered_map> +//#include <unordered_set> +//#include <vector> + +namespace doris { +namespace iceberg { + +// Forward declarations +class Type; +class StructType; +class ListType; +class MapType; +class NestedField; +class Schema; + +class SchemaParser { +public: + static const char* SCHEMA_ID; + static const char* IDENTIFIER_FIELD_IDS; + static const char* TYPE; + static const char* STRUCT; + static const char* LIST; + static const char* MAP; + static const char* FIELDS; + static const char* ELEMENT; + static const char* KEY; + static const char* VALUE; + static const char* DOC; + static const char* NAME; + static const char* ID; + static const char* ELEMENT_ID; + static const char* KEY_ID; + static const char* VALUE_ID; + static const char* REQUIRED; + static const char* ELEMENT_REQUIRED; + static const char* VALUE_REQUIRED; + + static std::unique_ptr<Schema> from_json(const std::string& json); + +private: + static std::unique_ptr<Type> _type_from_json(const rapidjson::Value& value); + static std::unique_ptr<StructType> _struct_from_json(const rapidjson::Value& value); + static std::unique_ptr<ListType> _list_from_json(const rapidjson::Value& value); Review Comment: warning: use of undeclared identifier 'rapidjson' [clang-diagnostic-error] ```cpp static std::unique_ptr<ListType> _list_from_json(const rapidjson::Value& value); ^ ``` ########## be/src/vec/exec/format/table/iceberg/schema_parser.h: ########## @@ -0,0 +1,73 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +//#include <rapidjson/document.h> +// +//#include <iostream> +//#include <memory> +//#include <string> +//#include <unordered_map> +//#include <unordered_set> +//#include <vector> + +namespace doris { +namespace iceberg { + +// Forward declarations +class Type; +class StructType; +class ListType; +class MapType; +class NestedField; +class Schema; + +class SchemaParser { +public: + static const char* SCHEMA_ID; + static const char* IDENTIFIER_FIELD_IDS; + static const char* TYPE; + static const char* STRUCT; + static const char* LIST; + static const char* MAP; + static const char* FIELDS; + static const char* ELEMENT; + static const char* KEY; + static const char* VALUE; + static const char* DOC; + static const char* NAME; + static const char* ID; + static const char* ELEMENT_ID; + static const char* KEY_ID; + static const char* VALUE_ID; + static const char* REQUIRED; + static const char* ELEMENT_REQUIRED; + static const char* VALUE_REQUIRED; + + static std::unique_ptr<Schema> from_json(const std::string& json); + +private: + static std::unique_ptr<Type> _type_from_json(const rapidjson::Value& value); + static std::unique_ptr<StructType> _struct_from_json(const rapidjson::Value& value); Review Comment: warning: use of undeclared identifier 'std' [clang-diagnostic-error] ```cpp static std::unique_ptr<StructType> _struct_from_json(const rapidjson::Value& value); ^ ``` ########## be/src/vec/exec/format/table/iceberg/schema_parser.h: ########## @@ -0,0 +1,73 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +//#include <rapidjson/document.h> +// +//#include <iostream> +//#include <memory> +//#include <string> +//#include <unordered_map> +//#include <unordered_set> +//#include <vector> + +namespace doris { +namespace iceberg { + +// Forward declarations +class Type; +class StructType; +class ListType; +class MapType; +class NestedField; +class Schema; + +class SchemaParser { +public: + static const char* SCHEMA_ID; + static const char* IDENTIFIER_FIELD_IDS; + static const char* TYPE; + static const char* STRUCT; + static const char* LIST; + static const char* MAP; + static const char* FIELDS; + static const char* ELEMENT; + static const char* KEY; + static const char* VALUE; + static const char* DOC; + static const char* NAME; + static const char* ID; + static const char* ELEMENT_ID; + static const char* KEY_ID; + static const char* VALUE_ID; + static const char* REQUIRED; + static const char* ELEMENT_REQUIRED; + static const char* VALUE_REQUIRED; + + static std::unique_ptr<Schema> from_json(const std::string& json); + +private: + static std::unique_ptr<Type> _type_from_json(const rapidjson::Value& value); + static std::unique_ptr<StructType> _struct_from_json(const rapidjson::Value& value); + static std::unique_ptr<ListType> _list_from_json(const rapidjson::Value& value); + static std::unique_ptr<MapType> _map_from_json(const rapidjson::Value& value); Review Comment: warning: use of undeclared identifier 'std' [clang-diagnostic-error] ```cpp static std::unique_ptr<MapType> _map_from_json(const rapidjson::Value& value); ^ ``` ########## be/src/vec/exec/format/table/iceberg/schema_parser.h: ########## @@ -0,0 +1,73 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +//#include <rapidjson/document.h> +// +//#include <iostream> +//#include <memory> +//#include <string> +//#include <unordered_map> +//#include <unordered_set> +//#include <vector> + +namespace doris { +namespace iceberg { + +// Forward declarations +class Type; +class StructType; +class ListType; +class MapType; +class NestedField; +class Schema; + +class SchemaParser { +public: + static const char* SCHEMA_ID; + static const char* IDENTIFIER_FIELD_IDS; + static const char* TYPE; + static const char* STRUCT; + static const char* LIST; + static const char* MAP; + static const char* FIELDS; + static const char* ELEMENT; + static const char* KEY; + static const char* VALUE; + static const char* DOC; + static const char* NAME; + static const char* ID; + static const char* ELEMENT_ID; + static const char* KEY_ID; + static const char* VALUE_ID; + static const char* REQUIRED; + static const char* ELEMENT_REQUIRED; + static const char* VALUE_REQUIRED; + + static std::unique_ptr<Schema> from_json(const std::string& json); + +private: + static std::unique_ptr<Type> _type_from_json(const rapidjson::Value& value); + static std::unique_ptr<StructType> _struct_from_json(const rapidjson::Value& value); Review Comment: warning: use of undeclared identifier 'rapidjson' [clang-diagnostic-error] ```cpp static std::unique_ptr<StructType> _struct_from_json(const rapidjson::Value& value); ^ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
