github-actions[bot] commented on code in PR #34985:
URL: https://github.com/apache/doris/pull/34985#discussion_r1605677771
##########
be/src/runtime/memory/mem_tracker_limiter.h:
##########
@@ -129,15 +129,30 @@ class MemTrackerLimiter final : public MemTracker {
__builtin_unreachable();
}
- static bool sys_mem_exceed_limit_check(int64_t bytes);
-
void set_consumption() { LOG(FATAL) << "MemTrackerLimiter set_consumption
not supported"; }
Type type() const { return _type; }
int64_t group_num() const { return _group_num; }
bool has_limit() const { return _limit >= 0; }
int64_t limit() const { return _limit; }
bool limit_exceeded() const { return _limit >= 0 && _limit <
consumption(); }
+ bool try_consume(int64_t bytes, bool force_tracker_overcommit = true) {
Review Comment:
warning: method 'try_consume' can be made const
[readability-make-member-function-const]
```suggestion
bool try_consume(int64_t bytes, bool force_tracker_overcommit = true)
const {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
