wuwenchi commented on code in PR #34257:
URL: https://github.com/apache/doris/pull/34257#discussion_r1603245455
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/analyzer/UnboundTableSinkCreator.java:
##########
@@ -72,6 +76,9 @@ public static LogicalSink<? extends Plan>
createUnboundTableSink(List<String> na
} else if (curCatalog instanceof HMSExternalCatalog) {
return new UnboundHiveTableSink<>(nameParts, colNames, hints,
partitions,
dmlCommandType, Optional.empty(), Optional.empty(), plan);
+ } else if (curCatalog instanceof IcebergExternalCatalog) {
Review Comment:
This check will be done when it comes to logic to physics:
```
private Pair<HMSExternalDatabase, HMSExternalTable> bind(CascadesContext
cascadesContext,
UnboundHiveTableSink<? extends Plan> sink) {
List<String> tableQualifier =
RelationUtil.getQualifierName(cascadesContext.getConnectContext(),
sink.getNameParts());
Pair<DatabaseIf<?>, TableIf> pair =
RelationUtil.getDbAndTable(tableQualifier,
cascadesContext.getConnectContext().getEnv());
if (pair.second instanceof HMSExternalTable) {
return Pair.of(((HMSExternalDatabase) pair.first),
(HMSExternalTable) pair.second);
}
throw new AnalysisException("the target table of insert into is not
a Hive table");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
