liaoxin01 commented on code in PR #34740:
URL: https://github.com/apache/doris/pull/34740#discussion_r1600900041
##########
be/src/vec/sink/writer/vtablet_writer.cpp:
##########
@@ -1411,7 +1414,6 @@ Status VTabletWriter::_send_new_partition_batch() {
}
void VTabletWriter::_do_try_close(RuntimeState* state, const Status&
exec_status) {
- SCOPED_TIMER(_close_timer);
Review Comment:
why delete this?
##########
be/src/vec/sink/writer/vtablet_writer.h:
##########
@@ -114,6 +106,10 @@ struct AddBatchCounter {
}
};
+struct WriteBlockCallbackContext {
Review Comment:
Only one variable, no need this structure？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
