zhannngchen commented on code in PR #34871:
URL: https://github.com/apache/doris/pull/34871#discussion_r1601275238


##########
be/src/olap/rowset/segment_v2/segment.cpp:
##########
@@ -290,6 +290,10 @@ Status Segment::_load_pk_bloom_filter() {
         return _load_pk_bf_once.call([this] {
             RETURN_IF_ERROR(_pk_index_reader->parse_bf(_file_reader, 
*_pk_index_meta));
             _meta_mem_usage += _pk_index_reader->get_bf_memory_size();
+            SegmentCache::CacheKey cache_key(_rowset_id, _segment_id);

Review Comment:
   It's better to decouple cache management and load index/bloomfilter



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to