morrySnow commented on code in PR #34894:
URL: https://github.com/apache/doris/pull/34894#discussion_r1601107287
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalOlapScan.java:
##########
@@ -311,6 +311,15 @@ public LogicalOlapScan withPreAggStatus(PreAggStatus
preAggStatus) {
hints, cacheSlotWithSlotName, tableSample, directMvScan,
projectPulledUp);
}
+ @Override
+ public LogicalOlapScan withRelationId(RelationId relationId) {
+ return new LogicalOlapScan(relationId, (Table) table, qualifier,
+ Optional.empty(), Optional.empty(),
+ selectedPartitionIds, partitionPruned, selectedTabletIds,
+ selectedIndexId, indexSelected, preAggStatus,
manuallySpecifiedPartitions,
+ hints, cacheSlotWithSlotName, tableSample, directMvScan,
projectPulledUp);
Review Comment:
cacheSlotWithSlotName should be removed
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/copier/LogicalPlanDeepCopier.java:
##########
Review Comment:
visitLogicalDeferMaterializeOlapScan should also add to relation id map
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/analyzer/UnboundTVFRelation.java:
##########
@@ -101,6 +101,11 @@ public Plan
withGroupExprLogicalPropChildren(Optional<GroupExpression> groupExpr
return new UnboundTVFRelation(relationId, functionName, properties,
groupExpression, logicalProperties);
}
+ @Override
+ public UnboundTVFRelation withRelationId(RelationId relationId) {
+ throw new RuntimeException("should not call UnboundTVFRelation's
withRelationId method");
Review Comment:
UnboundException
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalOneRowRelation.java:
##########
@@ -89,6 +89,11 @@ public Plan
withGroupExprLogicalPropChildren(Optional<GroupExpression> groupExpr
return new LogicalOneRowRelation(relationId, projects,
groupExpression, logicalProperties);
}
+ @Override
+ public LogicalOneRowRelation withRelationId(RelationId relationId) {
+ return new LogicalOneRowRelation(relationId, projects,
Optional.empty(), Optional.empty());
Review Comment:
should not impl, throw exception
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalEmptyRelation.java:
##########
@@ -81,6 +81,11 @@ public Plan
withGroupExprLogicalPropChildren(Optional<GroupExpression> groupExpr
return new LogicalEmptyRelation(relationId, projects, groupExpression,
logicalProperties);
}
+ @Override
+ public LogicalEmptyRelation withRelationId(RelationId relationId) {
+ return new LogicalEmptyRelation(relationId, projects,
Optional.empty(), Optional.empty());
Review Comment:
throw exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
