HappenLee commented on a change in pull request #7827:
URL: https://github.com/apache/incubator-doris/pull/7827#discussion_r789552392
##########
File path: be/src/vec/columns/column_complex.h
##########
@@ -63,6 +63,12 @@ class ColumnComplexType final : public COWHelper<IColumn,
ColumnComplexType<T>>
void insert_default() override { data.push_back(T()); }
+ void insert_many_defaults(size_t length) override {
Review comment:
try use resize
##########
File path: be/src/vec/columns/column_string.h
##########
@@ -203,6 +203,15 @@ class ColumnString final : public COWHelper<IColumn,
ColumnString> {
offsets.push_back(offsets.back() + 1);
}
+ void insert_many_defaults(size_t length) override {
+ size_t chars_old_size = chars.size();
+ chars.resize(chars_old_size + length);
+ memset(chars.data() + chars_old_size, 0, length);
+ for (size_t i = 0; i < length; i++) {
Review comment:
try to simd the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
