gavinchou commented on code in PR #34615:
URL: https://github.com/apache/doris/pull/34615#discussion_r1600009748
##########
gensrc/proto/cloud.proto:
##########
@@ -759,6 +761,8 @@ message GetVersionResponse {
repeated int64 table_ids = 4;
repeated int64 partition_ids = 5;
repeated int64 versions = 6;
+ repeated int64 version_update_times = 7;
Review Comment:
what's the single and multiple update_time for?
##########
cloud/src/meta-service/meta_service_txn.cpp:
##########
@@ -1043,10 +1043,14 @@ void
MetaServiceImpl::commit_txn(::google::protobuf::RpcController* controller,
}
// Save versions
+ int64_t version_update_time =
Review Comment:
add time unit as suffix
e.g. `version_update_time_ms`
pls. check all the other occurrences
##########
gensrc/proto/cloud.proto:
##########
@@ -662,6 +663,7 @@ message CommitTxnResponse {
repeated int64 partition_ids = 4;
repeated int64 versions = 5;
repeated TableStatsPB table_stats = 6;
+ optional int64 version_update_time = 7;
Review Comment:
What is this for? Why is version_update_time related to RecycleTxnPB
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
