zhannngchen commented on code in PR #34788:
URL: https://github.com/apache/doris/pull/34788#discussion_r1599326724
##########
be/src/exec/tablet_info.h:
##########
@@ -93,6 +93,7 @@ class OlapTableSchemaParam {
return _partial_update_input_columns;
}
std::string auto_increment_coulumn() const { return
_auto_increment_column; }
+ int32_t auto_increment_coulumn_unique_id() const { return
_auto_increment_column_unique_id; }
Review Comment:
typo: coulumn
##########
be/src/olap/rowset/segment_v2/segment_writer.cpp:
##########
@@ -751,7 +733,10 @@ Status
SegmentWriter::fill_missing_columns(vectorized::MutableColumns& mutable_f
FieldType::OLAP_FIELD_TYPE_BIGINT);
auto auto_inc_column =
assert_cast<vectorized::ColumnInt64*>(
mutable_full_columns[cids_missing[i]].get());
- auto_inc_column->insert(_auto_inc_id_allocator.next_id());
+ auto_inc_column->insert(
Review Comment:
Get column by name is better?
If you have to get the column by offset, you need to add a DCHECK to make
sure the column is the one you want.
##########
fe/fe-core/src/main/java/org/apache/doris/planner/OlapTableSink.java:
##########
@@ -322,6 +322,7 @@ public TOlapTableSchemaParam createSchema(long dbId,
OlapTable table, Analyzer a
for (Column col : table.getFullSchema()) {
if (col.isAutoInc()) {
schemaParam.setAutoIncrementColumn(col.getName());
+
schemaParam.setAutoIncrementColumnUniqueId(col.getUniqueId());
Review Comment:
can we get the unique id from BE instead? I think BE has full schema as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
