(doris) branch branch-2.1 updated: [fix][nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder (#34824)

[yiguolei]

This is an automated email from the ASF dual-hosted git repository.

yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/branch-2.1 by this push:
     new 47f0a6734ba [fix][nereids] fix misunderstanding about 
bothSideShuffleKeysAreSameOrder (#34824)
47f0a6734ba is described below

commit 47f0a6734ba33fa5613921250a1723359cbcf281
Author: xzj7019 <131111794+xzj7...@users.noreply.github.com>
AuthorDate: Tue May 14 15:17:34 2024 +0800

    [fix][nereids] fix misunderstanding about bothSideShuffleKeysAreSameOrder 
(#34824)
    
    Co-authored-by: zhongjian.xzj 
<zhongjian.xzj@zhongjianxzjdeMacBook-Pro.local>
---
 .../nereids/properties/ChildrenPropertiesRegulator.java    | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/properties/ChildrenPropertiesRegulator.java
 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/properties/ChildrenPropertiesRegulator.java
index 31bef9b89d0..038e2646a6d 100644
--- 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/properties/ChildrenPropertiesRegulator.java
+++ 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/properties/ChildrenPropertiesRegulator.java
@@ -497,16 +497,10 @@ public class ChildrenPropertiesRegulator extends 
PlanVisitor<Boolean, Void> {
             boolean isSatisfy = true;
             for (int i = 0; i < shuffleSideOutputList.size() && isSatisfy; 
i++) {
                 ExprId shuffleSideExprId = shuffleSideOutputList.get(i);
-                boolean found = false;
-                for (int j = 0; j < notShuffleSideOutputList.size() && !found; 
j++) {
-                    ExprId notShuffleSideExprId = 
notShuffleSideOutputList.get(j);
-                    if (shuffleSideExprId.equals(notShuffleSideExprId)
-                            || 
shuffleSideOutput.getEquivalenceExprIdsOf(shuffleSideExprId)
-                            .contains(notShuffleSideExprId)) {
-                        found = true;
-                    }
-                }
-                if (!found) {
+                ExprId notShuffleSideExprId = notShuffleSideOutputList.get(i);
+                if (!(shuffleSideExprId.equals(notShuffleSideExprId)
+                        || 
shuffleSideOutput.getEquivalenceExprIdsOf(shuffleSideExprId)
+                        .contains(notShuffleSideExprId))) {
                     isSatisfy = false;
                 }
             }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org