mrhhsg commented on code in PR #34703:
URL: https://github.com/apache/doris/pull/34703#discussion_r1597532952
##########
be/src/vec/exec/join/process_hash_table_probe_impl.h:
##########
@@ -258,7 +259,7 @@ Status ProcessHashTableProbe<JoinOpType,
Parent>::do_process(HashTableType& hash
need_null_map_for_probe &&
ignore_null > (hash_table_ctx.keys,
hash_table_ctx.bucket_nums.data(),
probe_index, build_index, probe_rows,
_probe_indexs.data(),
- _probe_visited, _build_indexs.data());
+ _probe_visited, _build_indexs.data(),
has_mark_join_conjunct);
Review Comment:
There are some cases already covered this code in
`regression-test/suites/nereids_p0/join/test_mark_join.groovy`,
`regression-test/suites/nereids_p0/subquery/subquery_unnesting.groovy`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
