yiguolei commented on code in PR #34664:
URL: https://github.com/apache/doris/pull/34664#discussion_r1597328810
##########
be/src/pipeline/pipeline_fragment_context.cpp:
##########
@@ -1167,7 +1167,8 @@ Status
PipelineFragmentContext::_create_operator(ObjectPool* pool, const TPlanNo
op.reset(new StreamingAggOperatorX(pool, next_operator_id(),
tnode, descs));
RETURN_IF_ERROR(cur_pipe->add_operator(op));
} else {
- if (_runtime_state->enable_agg_spill() &&
!tnode.agg_node.grouping_exprs.empty()) {
+ if ((_runtime_state->enable_force_spill() ||
_runtime_state->enable_agg_spill()) &&
Review Comment:
DO not modify like this.
in enable_agg_spill() method add a check enable_force_spill
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
