eldenmoon commented on code in PR #34501:
URL: https://github.com/apache/doris/pull/34501#discussion_r1596219119
##########
be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:
##########
@@ -394,9 +394,11 @@ class InvertedIndexColumnWriterImpl : public
InvertedIndexColumnWriter {
_parser_type !=
InvertedIndexParserType::PARSER_NONE) {
// in this case stream need to delete after
add_document, because the
// stream can not reuse for different field
- _char_string_reader->init(v->get_data(),
v->get_size(), false);
+ std::unique_ptr<lucene::util::Reader>
char_string_reader = nullptr;
+
RETURN_IF_ERROR(create_char_string_reader(char_string_reader));
Review Comment:
will this impact performance? maybe a test is needed to prevent from bad
performance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
