liaoxin01 commented on code in PR #34485:
URL: https://github.com/apache/doris/pull/34485#discussion_r1596163228
##########
be/src/runtime/load_stream.cpp:
##########
@@ -223,12 +223,13 @@ Status TabletStream::close() {
bthread::Mutex mu;
std::unique_lock<bthread::Mutex> lock(mu);
bthread::ConditionVariable cv;
- auto wait_func = [this, &mu, &cv] {
+ auto wait_func = [this, &cv] {
signal::set_signal_task_id(_load_id);
for (auto& token : _flush_tokens) {
- token->wait();
+ if (token != nullptr) {
+ token->wait();
+ }
}
- std::lock_guard<bthread::Mutex> lock(mu);
Review Comment:
why remove this lock？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
