github-actions[bot] commented on code in PR #34515:
URL: https://github.com/apache/doris/pull/34515#discussion_r1593348260


##########
be/src/olap/storage_engine.h:
##########
@@ -233,6 +233,8 @@ class StorageEngine {
 
     std::set<string> get_broken_paths() { return _broken_paths; }
 
+    int64_t memory_limitation_bytes_per_thread_for_schema_change() const;

Review Comment:
   warning: function 'memory_limitation_bytes_per_thread_for_schema_change' 
should be marked [[nodiscard]] [modernize-use-nodiscard]
   
   ```suggestion
       [[nodiscard]] int64_t 
memory_limitation_bytes_per_thread_for_schema_change() const;
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to