xiaokang commented on code in PR #34315:
URL: https://github.com/apache/doris/pull/34315#discussion_r1593329107
##########
be/src/olap/tablet_manager.h:
##########
@@ -73,7 +73,10 @@ class TabletManager {
// If `is_drop_table_or_partition` is true, we need to remove all remote
rowsets in this tablet.
Status drop_tablet(TTabletId tablet_id, TReplicaId replica_id, bool
is_drop_table_or_partition);
- TabletSharedPtr find_best_tablet_to_compaction(
+ // Find two tablets.
+ // One with the highest score to execute single compaction,
+ // the other with the highest score to execute cumu or base compaction.
+ std::vector<TabletSharedPtr> find_best_tablet_to_compaction(
Review Comment:
find_best_tablets_to_compaction
##########
be/src/olap/single_replica_compaction.h:
##########
@@ -37,6 +37,8 @@ class SingleReplicaCompaction final : public CompactionMixin {
Status prepare_compact() override;
Status execute_compact() override;
+ inline CompactionType real_compact_type() const { return _compaction_type;
}
Review Comment:
why not just compaction_type() ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
