morningman commented on a change in pull request #7526:
URL: https://github.com/apache/incubator-doris/pull/7526#discussion_r783710156
##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/VariableMgr.java
##########
@@ -304,17 +286,30 @@ public static void setLowerCaseTableNames(int mode)
throws DdlException {
// global variable persistence
public static void write(DataOutputStream out) throws IOException {
- defaultSessionVariable.write(out);
+ SessionVariable variablesToWrite = defaultSessionVariable;
+ if (Catalog.isCheckpointThread()) {
Review comment:
Not exactly, the `write` method may be called in:
1. Checkpoint thread
2. when calling `/dump` http api
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
