zhiqiang-hhhh commented on code in PR #34473:
URL: https://github.com/apache/doris/pull/34473#discussion_r1592411490
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/ComputePrecisionForRound.java:
##########
@@ -37,7 +37,8 @@ default FunctionSignature computePrecision(FunctionSignature
signature) {
Expression floatLength = getArgument(1);
int scale;
- if (floatLength.isLiteral() || (floatLength instanceof Cast &&
floatLength.child(0).isLiteral()
+ if ((floatLength.isLiteral() && floatLength.getDataType()
instanceof Int32OrLessType)
Review Comment:
in what situation would scale does not have integer type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
