morrySnow commented on code in PR #34483:
URL: https://github.com/apache/doris/pull/34483#discussion_r1592150445


##########
regression-test/suites/query_p0/sql_functions/datetime_functions/test_date_function.groovy:
##########
@@ -222,6 +222,14 @@ suite("test_date_function") {
     qt_sql """ select date_add(test_datetime, INTERVAL 2 MINUTE) result from 
${tableName}; """
     qt_sql """ select date_add(test_datetime, INTERVAL 2 SECOND) result from 
${tableName}; """
 
+    String explainResult
+    explainResult = sql("select * from ${tableName} where test_datetime >= 
date_add('2024-01-16',INTERVAL 1 day);")
+    assertFalse(explainResult.contains("date_add"))
+    explainResult = sql("select * from ${tableName} where test_datetime >= 
months_add('2024-01-16',1);")
+    assertFalse(explainResult.contains("months_add"))
+    explainResult = sql("select * from ${tableName} where test_datetime >= 
years_add('2024-01-16',1);")
+    assertFalse(explainResult.contains("years_add"))

Review Comment:
   we should check the result is right, wo need to check contains '2025-01-16'. 
btw, u should use
   ```
   explain {
       sql """ ... """
       contains "...."
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to