This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new d127d67ebe9 Revert "[fix](csv-reader) fix column split error when
there is escape character (#34364)"
d127d67ebe9 is described below
commit d127d67ebe989484bbdf340a4de5b79ded56eecc
Author: yiguolei <yiguo...@gmail.com>
AuthorDate: Tue May 7 13:36:11 2024 +0800
Revert "[fix](csv-reader) fix column split error when there is escape
character (#34364)"
This reverts commit 971e10a9db782c9986b20e1209468e4d7aeedf71.
---
be/src/vec/exec/format/file_reader/new_plain_text_line_reader.cpp | 7 ++++---
be/src/vec/exec/format/file_reader/new_plain_text_line_reader.h | 2 --
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/be/src/vec/exec/format/file_reader/new_plain_text_line_reader.cpp
b/be/src/vec/exec/format/file_reader/new_plain_text_line_reader.cpp
index fefd5ecae67..c395e52f36b 100644
--- a/be/src/vec/exec/format/file_reader/new_plain_text_line_reader.cpp
+++ b/be/src/vec/exec/format/file_reader/new_plain_text_line_reader.cpp
@@ -143,12 +143,13 @@ void EncloseCsvLineReaderContext::_on_normal(const
uint8_t* start, size_t& len)
}
void EncloseCsvLineReaderContext::_on_pre_match_enclose(const uint8_t* start,
size_t& len) {
+ bool should_escape = false;
do {
do {
if (start[_idx] == _escape) [[unlikely]] {
- _should_escape = !_should_escape;
- } else if (_should_escape) [[unlikely]] {
- _should_escape = false;
+ should_escape = !should_escape;
+ } else if (should_escape) [[unlikely]] {
+ should_escape = false;
} else if (start[_idx] == _enclose) [[unlikely]] {
_state.forward_to(ReaderState::MATCH_ENCLOSE);
++_idx;
diff --git a/be/src/vec/exec/format/file_reader/new_plain_text_line_reader.h
b/be/src/vec/exec/format/file_reader/new_plain_text_line_reader.h
index 0b0d9f133fa..babfc13641a 100644
--- a/be/src/vec/exec/format/file_reader/new_plain_text_line_reader.h
+++ b/be/src/vec/exec/format/file_reader/new_plain_text_line_reader.h
@@ -135,7 +135,6 @@ public:
inline void refresh_impl() {
_idx = 0;
- _should_escape = false;
_result = nullptr;
_column_sep_positions.clear();
_state.reset();
@@ -169,7 +168,6 @@ private:
const size_t _column_sep_len;
size_t _idx = 0;
- bool _should_escape = false;
const std::string _column_sep;
std::vector<size_t> _column_sep_positions;
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
