zhiqiang-hhhh commented on code in PR #34391:
URL: https://github.com/apache/doris/pull/34391#discussion_r1590930311
##########
be/src/vec/functions/round.h:
##########
@@ -480,15 +477,8 @@ struct Dispatcher {
}
}
- // NOTE: This function is only tested for truncate
- // DO NOT USE THIS METHOD FOR OTHER ROUNDING BASED FUNCTION UNTIL YOU KNOW
EXACTLY WHAT YOU ARE DOING !!!
static ColumnPtr apply_vec_vec(const IColumn* col_general, const IColumn*
col_scale) {
Review Comment:
this method can not be used for ceil
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
